search

buddycloud / buddycloud.com

buddycloud static site generation and gh_pages
http://buddycloud.com
Other
18 stars 18 forks source link

small css fixes #34

Open imaginator opened 10 years ago

imaginator commented 10 years ago

Note to myself:

<li> tags are outside the margin and look odd. <h2> we needs love: the horizontal line above the H2 tag just looks odd. Time to get rid of it forever.

vitoravelino commented 10 years ago

That's gone with the refactor.

imaginator commented 10 years ago

Two issues with h2:

vitoravelino commented 10 years ago

First, if the content is different from the original, open a new issue.

  1. Yeah, h1 with page-header class has a horizontal line (default from bootstrap). I personally like it because it indicates that it's a highlighted title. You can remove it by removing page-header class.
  2. It's just a <hr /> tag. It made sense for me to separate the sections. Maybe I added too much and it would be better to just have between main sections instead of each one (including subsections). It's just a matter of content organization.
  3. Yeah, it's less than the previous one. I didn't change the default from bootstrap. I agree that it could have a bit bigger spacing. I don't know the magic numbers to put it. This change should be done in buddycloud-styles.
imaginator commented 10 years ago

True - the HRs are little overpowering. Originally Jan was going to remove the last top line (from h2) too but didn't get a chance before leaving for Japan.