search

buddycloud / buddycloud.com

buddycloud static site generation and gh_pages
http://buddycloud.com
Other
18 stars 18 forks source link

slate-api: right hand column colours #71

Open imaginator opened 9 years ago

imaginator commented 9 years ago

colours should be:

screenshot 2014-07-07 15 37 07

reference screenshot 2014-07-07 15 41 13

vitoravelino commented 9 years ago

I'd like to show you how it's gonna be if I apply #69, #70 and #71 (this). Are you sure? It doesn't look good imho.

y43mm-jx9xh-

guilhermesgb commented 9 years ago

I'd keep it without these color changes. Instead I would suggest the focus be on any changes that make the content easier to read. On Jul 26, 2014 6:48 PM, "Vítor Avelino" notifications@github.com wrote:

I'd like to show you how it's gonna be if I apply #69 https://github.com/buddycloud/buddycloud.com/issues/69, #70 https://github.com/buddycloud/buddycloud.com/issues/70 and #71 https://github.com/buddycloud/buddycloud.com/issues/71 (this). Are you sure? It doesn't look good imho.

[image: y43mm-jx9xh-] https://cloud.githubusercontent.com/assets/188554/3712344/003d21fc-150e-11e4-8a14-0b7f1f4dbfd8.png

— Reply to this email directly or view it on GitHub https://github.com/buddycloud/buddycloud.com/issues/71#issuecomment-50249586 .

imaginator commented 9 years ago

Changes look good imho :)

imaginator commented 9 years ago

There seems to be some background colour behind the "Posts" title. Is that planned?

vitoravelino commented 9 years ago

Okay, I'll make the changes. It's your call. Maybe the syntax highlighting will be a problem because it's prepared to be used on a dark background.

About the title background, it's been there since always.