buddycloud / deprecated-buddycloud-server

A buddycloud server written in Node.
http://buddycloud.org
Apache License 2.0
139 stars 12 forks source link

Missing post ID# #72

Closed lloydwatkin closed 12 years ago

lloydwatkin commented 12 years ago

When I make a post using smack library I receive an IQ result informing me that the post has been made but the ID attribute is missing for the item:

<iq id="o8O53-4" to="twinkle@my-server/BC_TEST_CLIENT" from="channels.my-server" type="result">
    <pubsub xmlns="http://jabber.org/protocol/pubsub">
        <publish xmlns="http://jabber.org/protocol/pubsub">
            <item></item>  <--- should have ID attribute here
        </publish>
    </pubsub>
</iq>

This is running the latest download version of the server 0.3.4 I believe on a centOS system.

Schnouki commented 12 years ago

In your original post, did you add an id tag, even if empty? Has the post been added to the DB, and if so, what's its ID? What's in the server log about this post?

Le 10 août 2012 à 17:54 CEST, Lloyd Watkin a écrit :

When I make a post using smack library I receive an IQ result informing me that the post has been made but the ID attribute is missing for the item:

<iq id="o8O53-4" to="twinkle@my-server/BC_TEST_CLIENT" from="channels.my-server" type="result">
    <pubsub xmlns="http://jabber.org/protocol/pubsub">
        <publish xmlns="http://jabber.org/protocol/pubsub">
            __<item></item>__
        </publish>
    </pubsub>
</iq>

This is running the latest download version of the server 0.3.4 I believe on a centOS system.


Reply to this email directly or view it on GitHub:

https://github.com/buddycloud/buddycloud-server/issues/72

Thomas/Schnouki

lloydwatkin commented 12 years ago

No ID sent with post. It does make it into the DB as I can see from webclient.

Will have to gather more info after the weekend.

lloydwatkin commented 12 years ago

Outgoing stanza:

this is a message $USER_NAME@$USER_SERVICENAME 2012-08-08T14:00:30.740Z

This is what it looks like in the database:

/user/twinkle@my-server/posts 72b75563-0294-410d-b6fb-ea61c7ebece7 2012-08-13 06:44:11.812
this is a message
  +
                               |                                      |  
        |                     <author>  
                                   +
                               |                                      |  
        |                         <name>twinkle@my-server</name>  
                                   +
                               |                                      |  
        |                     <uri>acct:twinkle@my-server</uri></author>  
                                   +
                               |                                      |  
        |  
                                   +                                   |                                      |  
        |                 <id>72b75563-0294-410d-b6fb-ea61c7ebece7</id><published>2012-08-13T06:44:11.812Z</published><updated>2012-08-13T06:44:11.812Z</updated><link rel="self" href="xmpp:channels.my-server?pubsub;action=retrieve;node=/user/twinkle@my-server/posts;item=72b75563-0294-410d-b6fb-ea61c7ebece7"/><verb xmlns="http://activitystrea.ms/spec/1.0/">post</verb><object xmlns="http://activitystrea.ms/spec/1.0/"><object-type>note</object-type></object></entry>
lloydwatkin commented 12 years ago

Here's the log from a request https://gist.github.com/7b0f607d22ff193ff3e0

Schnouki commented 12 years ago

@lloydwatkin I wasn't able to reproduce this issue with latest master. Does it still happen on your side?

Schnouki commented 12 years ago

Hmmm, the "node" attribute is missing from <publish/> as well. Looking at the code, I can't figure how this could happen.

lloydwatkin commented 12 years ago

I've tracked this down to "not an issue with the server". It seems the test suite is stripping attributes on the element. Found it was doing the same thing with the java server and I can clearly see that the java server is sending back the id attribute.