search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Template Picker Core Code #106

Closed hnla closed 7 years ago

hnla commented 7 years ago

TIcket covers creating/ porting template picker in existing Nouveau plugin to core BP admin settings.

boonebgorges commented 7 years ago

Should maybe get a separate ticket, but I wanted to note that we should have documentation - at least internal documentation - describing best practices for registering third-party template packs. At the moment, it looks like it requires some combination of proper file headers + filter on 'next_template_packs_locations' etc.

hnla commented 7 years ago

and 'next_template_packs_locations' exists only in the template plugin file next-template-packs.php which moving forward wouldn't exist with template packs essentially using budypress-functions.php for their essential routines.

I'm not sure how we do register a new pack can it be as simple as scanning bp-templates dir for packs and then including a simple file with a template_pack_locations array filter?

boonebgorges commented 7 years ago

I'm not sure how we do register a new pack can it be as simple as scanning bp-templates dir for packs and then including a simple file with a template_pack_locations array filter?

Something like this is probably fine for v1. I don't think we must (or even should) emphasize the ability to roll your own template pack. But there should be some system that we use internally, which should be theoretically usable by a plugin.

hnla commented 7 years ago

Ah ok, yes technically only BP creates these template packs, we know what ones we have so we create our internal array to register those packs, & agree we don't necessarily encourage rolling own packs at this stage.

On 21/03/2017 12:08, Boone Gorges wrote:

I'm not sure how we do register a new pack can it be as simple as
scanning bp-templates dir for packs and then including a simple
file with a template_pack_locations array filter?

Something like this is probably fine for v1. I don't think we must (or even should) emphasize the ability to roll your own template pack. But there should be some system that we use internally, which should be theoretically usable by a plugin.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/buddypress/next-template-packs/issues/106#issuecomment-288059262, or mute the thread https://github.com/notifications/unsubscribe-auth/AAee2xiyFNep4TvYaBHkdvoYpym-gJamks5rn73VgaJpZM4MhBCT.

No virus found in this message. Checked by AVG - www.avg.com http://www.avg.com/email-signature Version: 2016.0.8007 / Virus Database: 4767/14158 - Release Date: 03/21/17

mercime commented 7 years ago

Related: BP Trac #7157

paulgibbs commented 7 years ago

This has been done in BP now; see above mentioned ticket.