search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Default template selection principles #107

Closed hnla closed 7 years ago

hnla commented 7 years ago

Ticket will cover the nature of how we set template selection by default.

We will decide whether new installs will automatically default to latest/Nouveau template pack & existing installations to bp-default with the option for those existing to switch up to new templates.

Ticket to cover setting the defaults and testing these on various installs.

boonebgorges commented 7 years ago

I assume that the logic will be: existing sites upgrading will keep bp-legacy, while new installations will get bp-nouveau.

This should mostly work out of the box. _bp_theme_package_id is already set to 'legacy' on existing installations. We'll change the default to 'nouveau'. But because the next-template-pack architecture requires a bit of an installation routine for packs (parsing the file header and setting _next_template_packs_package_data) it's possible that we'll need some upgrade routine that fills in missing metadata for bp-legacy installations.

hnla commented 7 years ago

So we need that dealt with which I think doesn't present a huge problem plus the routine to effect the core admin screen in bp settings to build the switcher template pack switching which as it's pretty much functional in the plugin to a 100% hopefully is more or less a copy paste task.

The task here in a nutshell boils down to running through next-template-packs.php in the plugin root and identifying what needs to be ported into bp core and where once that's completed the new template pack should run from the /bp-nouveau/ under /bp-templates/.

One thought while it's in mind, we should be careful about naming things too specifically e.g where we have many references to 'next' in strings as this string is a specific reference to a template pack where we need to be more generic dropping the _next_

paulgibbs commented 7 years ago

This is surprisingly trivial, given all our work in our installation/upgrade methods in the past.

It's a one liner: https://gist.github.com/anonymous/b391227771a842c70d4e39771e45cdf1

hnla commented 7 years ago

Now we're ported to core closing.