Template function tags merging to one - bp trac ticket.

[hnla]

This is just a reminder to look at and have a think about... https://buddypress.trac.wordpress.org/ticket/7071

[imath]

So the above commit should help garrett-eclipse to filter whether to display some meta to the current user.

@hnla I'd like to also use this template tag for the groups single item header (cover or not).

But there's some inconsistency between the groups loop, the regular group header and the cover image header.

In the groups loop, the item meta is inside the buttons container. In the regular group header item meta contains the buttons container. The cover image header is actually the only one to separate both container.

Could we avoid this ?

and instead have: for the groups loop

<div id="action"></div>
<div id="meta"></div>

& for the regular group header

<div id="item-meta"></div>
<div id="item-buttons"></div>

[hnla]

Yep this sounds like one of the oh so many little variances that we have, you'll start to get why I always mentioned template markup and need to strip it back and re-build without oddities.

We can do what we like or what we must with these templates this is of prime importance (there are more issues like this one to be tackled) I'll take a look and ponder what's best, however if you need to resolve do so, add applicable classes that suit if necessary and ping me when done and we'll check it over.

Getting markup that is consistant, and semantic is key to being able to style and script effectively and without confusion when trying to work through stylesheets.

To answer the question in the example above: Yes essentially we want free standing elements, that are in the flow of the doc and only live within a parent or ancestor when it absolutely makes sense, so 'meta' nested in 'button' doesn't work and only causes us issues at some point.

Likely styles will break initially though but we have to expect that until I can upload the new ones then set about tidying little bits like this.