search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

bp_search_input_name() does not exist > fatal error #14

Closed imath closed 8 years ago

imath commented 8 years ago

@hnla i guess this function is missing on your latest commit...

imath commented 8 years ago

bp_search_placeholder() is also missing

imath commented 8 years ago

bp_get_search_input_name() is also missing

hnla commented 8 years ago

?? I really can't replicate any fatal errors here, updated the local from origin, updated BP, search works fine for me so what am I missing?

imath commented 8 years ago

Deactivate the friends component, then go to activity

all the functions i've quoted are not in BuddyPress or the template pack for me

imath. http://profiles.wordpress.org/imath/

Le 27 mai 2016 à 18:12, Hugo - hnla notifications@github.com a écrit :

?? I really can't replicate any fatal errors here, updated the local from origin, updated BP, search works fine for me so what am I missing?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

hnla commented 8 years ago

I'll remove that file in due course.

hnla commented 8 years ago

and didn't mean to post commit to this ticket so re-opening as not sure whether there is still an issue here - object nav is corrected for the moment until I can remove it.

imath commented 8 years ago

I just rechecked again, there's no function named bp_get_search_input_name() into the template pack or into BuddyPress.

hnla commented 8 years ago

https://buddypress.trac.wordpress.org/ticket/6844

imath commented 8 years ago

I see. But i think we can't commit to this repo using BuddyPress functions that are not yet committed to trunk!

I'm currently working on it to fix all fatals. But please for the future, make sure functions are available for everybody!

hnla commented 8 years ago

That should have been committed to trunk frankly, my bad.

hnla commented 8 years ago

mate why have you changed those menu elements to ul?

imath commented 8 years ago

@hnla Because it was breaking the layout. I also added back the div.item-list-tabs. I think it's ok to change selectors but in this case, we need to make sure the css has been updated so that the layout is not ugly and also make sure it hasn't break anything in JS.

hnla commented 8 years ago

Imath it will break the layout you can't change up markup and re-style at the same time it's too problematical, slow, and just unsettling to try and build a balanced stylesheet. the point is to change up tokens re-factor markup, and generally produce well formed templates, it will be difficult to do this in one hit on local dev and upload and also that prohibits others from following along.

On 28/05/2016 14:07, imath wrote:

@hnla https://github.com/hnla Because it was breaking the layout. I also added back the div.item-list-tabs. I think it's ok to change selectors but in this case, we need to make sure the css has been updated so that the layout is not ugly and also make sure it hasn't break anything in JS.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/buddypress/next-template-packs/issues/14#issuecomment-222307693, or mute the thread https://github.com/notifications/unsubscribe/AAee27yeqWcjfrd-3tC28aQUMnrhWT-oks5qGD4LgaJpZM4IoRmV.

No virus found in this message. Checked by AVG - www.avg.com http://www.avg.com Version: 2016.0.7598 / Virus Database: 4568/12312 - Release Date: 05/28/16

imath commented 8 years ago

i personaly think it's the best way to get lost, but if everybody agrees on this, i'll adapt.