search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Errors running grunt #141

Closed mercime closed 7 years ago

mercime commented 7 years ago

Attached is the screenshot of the errors for "Task "stylelint:scss" failed." all due to img.FB_profile_pic selectors in _bp_activity_entries.scss

stylelint-fail

hnla commented 7 years ago

Yes know about these and ignoring for the moment it isn't critical and a result of historical use of bad tokens that's hard to work around, with previous style lint config I set ignore patterns for certain classes like the above, in new postcss lint config not sure how the same is achieved.

For the moment there are more pressing concerns however choices to deal with will be...

1/ Find the equivalent ignore pattern for stylelint config 2/ Look to remove use of those class tokens and replace with, probably a more convoluted selector ancestral path, or new class tokens if possible.

hnla commented 7 years ago

@netweb if you have a moment could you look at config as I've struggled and failed to get ignore: option working in the selector patterns, if stylelint doesn't support them then we'll just need to pull those selectors out - possibly the better option frankly.

ntwb commented 7 years ago

The PR #143 fixes the first part of this issue, the 2nd part is included in the upcoming (later today) stylelint release stylelint v11.0.0