search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Update activity entry delete functionality #152

Closed hnla closed 7 years ago

hnla commented 7 years ago

Now we have refactored to use 'button' elements we need to pick up the data attr rather than the href link

r-a-y commented 7 years ago

Can I ask why the "Favorite" and "Delete" buttons were switched from the <a> element to the <button> element in the activity meta block? Switching to the <button> element, particularly moving the href to a data attribute, broke the JS.

The directory pages and all single profile and group pages use the <a> element for the buttons.

hnla commented 7 years ago

Unless the element is a strict link really they should use the 'button' element, I have been gradually updating the functions to set data-attr & updating the template tags to pass button args.

Am aware the change breaks the JS thats the reason for the tickets.

Originally I discussed with imath using the data attr to pass all relevant data to JS & would have rather all these links href had been set on a data attr.

Please argue a case for sticking to the href if you think it's better as it's a fair bit of work puzzling a check for button args & re-factoring the arrays to swap the href strings to data attr - having said that as we are providing element choice options we would need to adjust the action button args regardless so I''ll need to push on with that change.

r-a-y commented 7 years ago

154 has updated feedback so to avoid forking discussion, going to close this one.