buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

A new API for Component Directories nav #16

Closed imath closed 8 years ago

imath commented 8 years ago

Looking at this file https://github.com/buddypress/next-template-packs/blob/master/bp-templates/bp-nouveau/buddypress/common/nav/object-nav.php

makes me think we need to make things easier. Although i like the idea of a generic object-nav template, the first switch seems very scary to me.

So a bit like we have Single Item navigation, i think Component directory navigations could be interesting to ease this template.

imath commented 8 years ago

I've just committed about this issue, because i really think it makes the nav template simpler. I've left the common/nav/object-nav.php template although it's not used anymore because i'd like to have @hnla approval about using this new way of managing directory navs. Else, i'll revert the commit ;)

imath commented 8 years ago

Here's a screenshot to demonstrate the developer feedbacks: capture d ecran 2016-06-12 a 21 28 08

hnla commented 8 years ago

And was discussed on: https://github.com/buddypress/next-template-packs/commit/7d509f935d32cefae9c624a3c5bcaab73775ddbd