search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Why is Nouveau loading messages CSS again? #184

Closed paulgibbs closed 7 years ago

paulgibbs commented 7 years ago

In bp_nouveau_messages_enqueue_styles() it loads the mentions CSS, which is loaded in core in bp_activity_mentions_script().

Does anyone know the background why this was done, and what other core scripts are re-declared like this?

hnla commented 7 years ago

@paulgibbs Good question, that I'm not sure of the answer to, seems on face of it to have no reasoning.

Have we tested commenting out Nouveau's loading?

hnla commented 7 years ago

For that matter why is the BP JS file re-enqueued ( as per your original ticket title)?

paulgibbs commented 7 years ago

I haven't looked in the Git history for that file yet, maybe the commit message might reveal intent. Perhaps it was just to be totally isolated and stand-alone from Core, and not rely on Core's JS scripts. (at-mentions is one I would think we could want to always have in our core, though)

hnla commented 7 years ago

It's a mystery, this is why I like proper comments not just thinking phpdocs - as lovely as they are - are sufficient, some things need the back story written :)

hnla commented 7 years ago

Looking further it seems to me the reason for this is simply to override the various handles and array dependencies to ensure that we load after nouveau css not BP css, on that basis this seems fine to me, so closing this ticket, if it is actually a problem please re-open and it can be looked at further.