search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Update Profile Edit and Register screens #187

Closed mercime closed 7 years ago

mercime commented 7 years ago

After accessibility updates in BP Trac #7348 Grouping related form fields for Profile Edit/Register screens,

The changes in https://gist.github.com/mercime/5ef840fa316dffd4c82866ce17a7afb1 include the same changes in bp-legacy for the two files, We could add the markup removed here in core.

hnla commented 7 years ago

I need to check these. When you say move to core are we referring to core as in BP core, if so the name of the game here is, where possible to, to ensure markup isn't locked away in core but in template level, templates or functions.

I may be reading all this wrong though :) need to study your gist when there's a minute.

mercime commented 7 years ago

@hnla Per our DM in Slack, among others, I removed the profile description from register and profile-edit files because of duplication of said descriptions after a11y improvements in BP Trac #7348

Attached is the profile > edit screen screenshot before and after pull request xprofile-edit-all

hnla commented 7 years ago

Closing on PR merge.