buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Default search text function doesn't return user params as expected #202

Closed hnla closed 7 years ago

hnla commented 7 years ago

This is a hard problem to figure. bp_nouveau_search_default_text() in template-tags.php we echo the string for label or placeholder in this there is this line of code: if ( ! empty( $objects['secondary'] ) ) { echo $text = bp_get_search_default_text( $objects['secondary'] ); } If we pass params in we expect them returned, this query $objects['secondary'] in the groups create steps screen reads as 'create' if that var text is dumped it reads as the user param that might have been set however allow to run through normally and we override this somewhere with another default string Search Anything...

As I have no time to go hunting through functions working this all out I'm adding a ! $text to that query to force the use of the args passed in the true issue will need to be tracked down at a future time.

hnla commented 7 years ago

I resolved this elsewhere - probably should have referenced or closed this ticket then.