search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Common includes - template parts #4

Closed hnla closed 8 years ago

hnla commented 8 years ago

Not an issue as such but...

Can we keep an eye on: https://buddypress.trac.wordpress.org/ticket/6844

Where I've attempted to begin a process of identifying and extracting core markup out to template files either as functions(preferable in some circs to allow args to be passed) or template parts.

I've patched the install I'm running this template pack on for 6844.

I'm creating a new branch in 'next-template-packs' in which I'm re-factoring the dir search elements to use these new parts rather than older core functions mainly to just see if they make sense.

hnla commented 8 years ago

This should also open a discussion in general on creating folders for template-parts for more site-wide elements.

I think I like /includes/ possibly sub-divided into more specific areas such as 'nav', 'filters' but this may be overkill.

As this is an easily reversible area I may just do what feels right and we can revise and update as we go until we have what we consider best.

hnla commented 8 years ago

Closing this: Pretty much we seem settled on common/nav/, common/search/ etc.