search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Grunt tasks.. #45

Closed imath closed 8 years ago

imath commented 8 years ago

check domain, generate pot, minify, build...

About the scss thing i think @netweb opened a ticket about a npm module that doesn't require ruby. Ruby is a pain to install in El Capitan, so maybe we could use it ?

ntwb commented 8 years ago

Unfortunately my username on GitHub is @ntwb, fortunately I watch this repo :)

And yes, stylelint with the stylelint-config-wordpress config:

http://stylelint.io/ https://github.com/ntwb/stylelint-config-wordpress

See also: https://buddypress.trac.wordpress.org/ticket/7028

imath commented 8 years ago

Thanks a lot @ntwb i will check it for sure :)

hnla commented 8 years ago

Because I needed a local grunt environment to develop in I have created my own files and as I knew it implemented scsslint & rtl, along with some modified stricter rules to work to this time around.

If we get stylelint implemented for main project we'll add it for this as well.

As for things like 'build' and other tools do we strictly need them in what is a sort of subset of the main core files, surely at some point we simply transfer the files in to core alongside bp-legecy. bp-nouveau is only standalone for purposes of initial development.

imath commented 8 years ago

I see your point. I personaly need the js tools to make sure my javascript is optimized. So i'll probably start with this and the check textdomain/i18n tools.

And i was thinking that people wishing to contribute to style/scss thing, might not have the tools to generate css out of scss. But if you think it's not necessary, i'll follow you.

hnla commented 8 years ago

well I could add my gruntfile, but it's a messy file I use hacked around for a few projects, I can see the point of maybe providing a simple base level gruntfile for people to use just to run linting, css compile and jshint, but are we able to exclude those eventually or do we have to have a src/build structure which just seems like we're starting to overcomplicate things?.

Actually my grunt files are in the root and the root will never be copied to core only the /bp-nouveau/ dir and files under it so we could add I guess.

hnla commented 8 years ago

Imath problem with adding your gruntfile is I tried to pull down so I could push up and I now have to deal with my existing gruntfiles etc not being able to be merged, could we have not just kept these files locally for the moment until we can build something to suit all purposes?

imath commented 8 years ago

sure.