search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Groups Headers duplicated elements - breakout to include #46

Closed hnla closed 7 years ago

hnla commented 8 years ago

In the two header templates we have we describe the exact same item-action markup and functions.

This as it serves two files would be better broken out to it's own template include where adjustments only need be made once.

The name choice for the folder is just temp 'parts' :) please change, couldn't think of anything better as of this minute.

imath commented 8 years ago

Just like for the common folder, i wonder if it's really needed to create subfolders to contain only one file. So more than the name, if there's only one file in the subfolder, let's move it up and remove the subfolder if once we have finished reorganizing there's always one file per subfolder.

imath commented 8 years ago

Forget about my comment above, there's a "part" that can go in this folder the item-nav one, and i'll need the same organization for the members component :) So let's go with "parts". Sounds good!

hnla commented 8 years ago

Yep it was a sort of trial thing, wasn't really sure it was the right approach but we do re-use the same markup in various templates so we should only support it once in physical files. I hate naming things so 'part' was a sod it that will do for the moment excuse :)