search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Handling companion styles... or not! #47

Closed hnla closed 8 years ago

hnla commented 8 years ago

Not sure whether we want to load these styles or not. On balance I think not, they are or were specific to WP default themes and BP main styles, designed to smooth out rough edges and little problem areas.

It's a mild dilemma though as there ended up being quite a lot breakpoint adjustments, which currently are absent as I work through the re-factoring of the main styles.

The inclination is to build it all in the new main styles ( or base styles whatever we deem them to be) and I have done this for some elements and provided for mixin breakpoints at outset, the slight worry is this entails quite a bit of work replicating styles already written but not copyable to any great degree.

imath commented 8 years ago

Good point!

tbh I'm not sure. It's true people can easily add BuddyPress specific styles this way. Let's talk about it at next template pack chat.

mercime commented 8 years ago

Per our meeting in Slack last Thursday, July 21, 2016 @hnla said:

My view now is it's too much work to try and include those and feel it's easier that we move on, those styles would still beused for themes running bp-legacy.

I agree. Let's use the Twenty-* themes to test bp-nouveau.

hnla commented 8 years ago

cool... closing.