buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Ensure BP elements have unique tokens #49

Closed hnla closed 8 years ago

hnla commented 8 years ago

In some circumstances BP uses rather too generic a token string that can inadvertently inherit properties from it's parent themes styles :(

An example is the loops pagination markup where we class the parent with pagination in twentyfifteen we inherit styles already proscribed for a class 'pagination'

Pagination is addressed in commit below.

All bp elements need checking and where a name appears too generic something more specific needs adding and BP styles hung on that.

The exception to this - just to make things awkward! - is where we do need to allow a theme to style our elements e.g links or buttons .button is a common class and might be required and shouldn't be changed but a bp-button added to hang styles on that are required to deal with the element in a BP specific layout context.