buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

BP navigation classes & naming - generic. #61

Closed hnla closed 8 years ago

hnla commented 8 years ago

This ticket follows on from #9 which I'll close at some point soon and let this one cover this aspect of classes for navs.

I'm effecting some changes to the class tokens for our navigation to try and get us away from visual references/semantics to more function based semantics , so the use of 'tabs' is not correct on generic navs unless it's a class referencing 'tabs' and which actually does then represent those links as visual tabs; Likewise 'item' and 'list' need to change item is slightly too vague and general, & list perhaps obvious.

I'm updating the function bp_nouveau_directory_type_tabs_class just to swap out the use of tab where found - this I realise could break stuff so checking as carefully as possible to see where those tokens strings may have been used i.e referenced in JS files.

On the nav wrapper item-list-tabs I'm adding: bp-navs dir-navs

_bpnavs simply lets me know I'm dealing with the parent wrapper & navs generally, dir-navs dirs rather than single screens the class subnav exists on the ul and as ID on the bp-nav wrapper so we'll leave things like that for the moment.

I'll not remove the instances of item-list-tabs just yet until I'm sure I have changes all the selector hooks and found all JS references if any.

imath commented 8 years ago

I use item-list-tabs only once in buddypress-nouveau.js, so it will be pretty easy to update this for whatever suits best :)

hnla commented 8 years ago

ok I'll deal with that if necessary - also I'm messing about a bit with template-tag functions, you may want to adjust but you'll see where in a moment.