hnla
commented
8 years ago I haven't tracked this down precisely but the issue prompting ticket is not actually with the data.object checks as above but that on the group avatar upload screen where we have an existing avatar and we're a group
despite what I add to the avatars/ index.php we have the message from core displayed:
'has_avatar_warning' => __( 'If you'd like to delete the existing profile photo but not upload a new one, please use the delete tab.', 'buddypress' )
bp-core/bp-core-attachements.php L: 614
`
In _attachments/avatars/index.php L:36
We check data.object is 'user' this appears to return true when on the groups manage screens ( avatar upload/edit ) when it shouldn't.
N.b I've updated the message string in this section to use the newer function
<?php bp_nouveau_user_feedback( 'group-avatar-delete-info' ); ?>