search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Groups - single: group meta function re-factoring #87

Closed hnla closed 7 years ago

hnla commented 8 years ago

Due to confusion partly; group header templates both rendered type, last active, descrip type meta both in template and via the bp_nouveau_group_meta()

In an attempt to make best sense of our preferred approach and while trying to re-factor template header layout it proved too awkward to work with the function and it's combined string output - non flexible! and a slight pita to add markup and classes etc.

looking at the functions in groups/template-tags.php I've decided to take the echo function and in the if( bp_is_group() ) comment out the string return and replace with an array to object to allow me to grab array parts in various template sections e.g: <p class="highlight group-status"><strong><?php echo esc_html( bp_nouveau_group_meta()->status ); ?></strong></p>

I can then be free to add meta where required rather than trapped to one element, the current position for general meta is then used for the bp_nouveau_group_meta()->extra developers plugin meta if any.

This is reversible and currently only tested to work as described, they may be breakages not seen yet!

Feedback when the time comes is requested.

hnla commented 7 years ago

Closing, no feedback or opinions!

I may return to this as not 100% comfortable with printing out data from bp_nouveau_group_meta()->extra & might be better to build a template tag to handle this.