Open JoshuaKGoldberg opened 6 years ago
...but on the other hand, it looks very odd to output for numbers start : i float 0 7
. getNumericTypeNameFromNode
should actually retrieve all usages of the node, so that if it's not exported publicly, and never modified in its scope, it correctly gets set to int
.
This is particularly relevant with C# string and array indices: they don't accept floats.
All JavaScript/TypeScript numerics may be changed at any time to float-style values from integers. Similar to not outputting arrays, this needs to stop.