search

budimanjojo / talhelper

A tool to help creating Talos kubernetes cluster
https://budimanjojo.github.io/talhelper
BSD 3-Clause "New" or "Revised" License
310 stars 19 forks source link

missing core components #198

Closed soulwhisper closed 1 year ago

soulwhisper commented 1 year ago

Currently, the talhelper generated config do not contain controller-manager and scheduler images, talhelper show certain configs as "{}". And I could not patch it.

You can re-produce this issue by generate default config using talosctl and talhelper.

budimanjojo commented 1 year ago

Thanks for the issue!

You need to put kubernetesVersion field in talconfig.yaml to have it generated for you. Because without specifying it, it will default to whatever the default is with the Talos version you're using.

budimanjojo commented 1 year ago

Just tested it. If I put kubernetesVersion: v1.27.0 in talconfig.yaml, the generated config will have:

cluster:
  controllerManager:
    image: registry.k8s.io/kube-controller-manager:v1.27.0
  proxy:
    image: registry.k8s.io/kube-proxy:v1.27.0
  scheduler:
    image: registry.k8s.io/kube-scheduler:v1.27.0

Is this solution acceptable? There's also a validation in the code that will make sure the kubernetesVersion you provide is compatible with the Talos version the config will be generated with.

soulwhisper commented 1 year ago

Got it. Thanks.