search

budryerson / TFMini-Plus-I2C

Arduino library for the Benewake TFMini-Plus LiDAR distance sensor in I2C communication mode
27 stars 16 forks source link

bug fix in chksum #3

Closed profff closed 4 years ago

profff commented 4 years ago

when calculating checksum for request in TFMPI2C::sendCommand method that was made on reply frame array and with reply length

added dbg option for printing frames (req / ans / dat)

profff commented 4 years ago

I dont know if it's ok If I say thank's you for this lib in PR comments but I want to do it anyway ! :) I'm also about to merge it in a I2C/UART compliant lib if intrested

budryerson commented 4 years ago

Profff, OMG! I fixed the checksum calculation and the two printf()s that you pointed out. Thank you so much for paying attention and for your gentle correction. I considered and decided against integrating the UART and I2C libraries. People either use one or the other. But you go ahead. I am very interested to see what you come up with. Please let me know how I can help. All the best, Bud Ryerson San Francisco bud @ budryerson dot com

profff commented 4 years ago

ok cool you just made a change and did not merge the pull request ? so I can close it ?