search

budtmo / docker-android

Android in docker solution with noVNC supported and video recording
Other
8.91k stars 1.21k forks source link

Android 11 build issue with 32-bit image #310

Closed JoelWhitney closed 2 years ago

JoelWhitney commented 2 years ago

Purpose of changes

This changes the system image from x86 to x86_64 for Android 11. For whatever reason the Android 11 image built using x86 was resulting in an AVD that was missing Chrome and other applications (see Android 11.0 (x86) in images below). Changing to x86_64 resolves the issue

I debated changing the script to also tag the image based on system image budtmo/docker-android-x86-11.0 --> budtmo/docker-android-x86_64-11.0 but decided against it to keep the changes as minimal as possible

Android 10.0 (x86) Android 11.0 (x86) Android 11.0 (x86_64) Android 12.0 (x86_64)
image image image image

Types of changes

Put an x in the boxes that apply

How has this been tested?

I ran unit tests and deployed to our our production environment for Android testing. These change resolved issues we were seeing with the current image

codecov-commenter commented 2 years ago

Codecov Report

Merging #310 (8f1c4bf) into master (cd63313) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #310   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files           2        2           
  Lines         130      130           
=======================================
  Hits          129      129           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cd63313...8f1c4bf. Read the comment docs.

JoelWhitney commented 2 years ago

After pushing this PR I updated everything on my machine and had the same exact issue with my Android 11 x86 emulator. This must be an issue with the latest version of that system image? Either way I changed the system image to the x86_64 image like above and everything was fine