Added selenium application name capability for AVD appium node registration

AlenK123 commented 2 years ago

Purpose of changes

As of right now theres no way to run tests on a spesific selenium gird node, so I wanted to implement the applicationName capabilit

Types of changes

Put an x in the boxes that apply

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

Localy on my machine

AlenK123 commented 2 years ago

Cool!! I’ll add it and update the pull request

On Wed, 16 Feb 2022 at 11:48 Budi Utomo @.***> wrote:

@.**** requested changes on this pull request.

sorry for a long waiting time @AlenK123 https://github.com/AlenK123

In src/app.py https://github.com/budtmo/docker-android/pull/315#discussion_r807735403:

@@ -151,9 +151,10 @@ def appium_run(avd_name: str): selenium_port = int(os.getenv('SELENIUM_PORT', 4444)) selenium_timeout = int(os.getenv('SELENIUM_TIMEOUT', 30)) selenium_proxy_class = os.getenv('SELENIUM_PROXY_CLASS', 'org.openqa.grid.selenium.proxy.DefaultRemoteProxy')

application_name = os.getenv('APPLICATION_NAME', avd_name)

maybe we should rename it to SELENIUM_APPLICATION_NAME, so we know that this is used for capability thing. and you should also add it in the README_APPIUM_AND_SELENIUM.md

— Reply to this email directly, view it on GitHub https://github.com/budtmo/docker-android/pull/315#pullrequestreview-884237783, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ2HJQ3RA4AYPD7MATW3EODU3NXG5ANCNFSM5K2TEYZA . You are receiving this because you were mentioned.Message ID: @.***>

budtmo commented 2 years ago

there is no response, so I will closed the PR. feel free to reopen it

budtmo / docker-android