search

budude2 / openfpga-GBC

193 stars 5 forks source link

Change luminance implementation for original display modes #56

Open Supermetz opened 1 month ago

Supermetz commented 1 month ago

The current luminance implementation for original display modes interferes with already grayscaled palettes.

For example, if you load the original Analogue GB grayscale palette, which is FFFFFFADADAD52525200000000000000, and take a screenshot, this is what it currently looks like: current

This is how original cartridge screenshots look like when taken with Analogue's core and original display modes: how-it-should-be

This pull request restores the original behavior.

I also changed the default palette to Analogue's GB FFFFFFADADAD52525200000000000000.

Supermetz commented 1 month ago

I like the new approach of not loading a palette when the original display modes are enabled. But this also has some side effects especially noticeable in screenshots: The default greyscale palette does not match Analogues GB palette. So i commited another change.