search

budziq / rust-skeptic

Test your Rust Markdown documentation via Cargo
Apache License 2.0
285 stars 43 forks source link

Bump pulldown-cmark to 0.5 #108

Closed eclipseo closed 3 years ago

eclipseo commented 5 years ago

Signed-off-by: Robert-André Mauchin zebob.m@gmail.com

eclipseo commented 5 years ago

get_offset is deprecated too, but it' above my skill to upgrade it:

the get_offset method on the parser was removed. Its semantics were poorly defined and only provided users with the start offset of the next event. To get proper source mapping information which includes the entire source range for each event, upgrade the Parser to an OffsetIter using the into_offset_iter method. This produces an iterator over (Event, Range) tuples.

Can you help updating it?

ignatenkobrain commented 4 years ago

@budziq @GuillaumeGomez ping?

GuillaumeGomez commented 4 years ago

Who dares *summon* me in here?

GuillaumeGomez commented 4 years ago

But more seriously: why was I pinged?

ignatenkobrain commented 4 years ago

@GuillaumeGomez whoops, I just noticed that you were the author of the patch and not committer. sorry :/

GuillaumeGomez commented 4 years ago

No problem, good luck. ;)

ignatenkobrain commented 4 years ago

ping @budziq

djc commented 3 years ago

Closing this in favor of #126, thanks for the contribution!