bueltge / addquicktag

This plugin makes it easy to add Quicktags to the html - and visual-editor.
http://wordpress.org/extend/plugins/addquicktag/
GNU General Public License v3.0
17 stars 10 forks source link

Not visible after update to WP 5.6 #48

Closed cargeo closed 3 years ago

cargeo commented 3 years ago

Since WP 5.6 the Quicktags field is no longer visible in editor. This is probably caused by WP's new jQuery library.

bueltge commented 3 years ago

Hello @cargeo I tested it with WP 5.7-beta and it works, also in the Gutenberg editor, Classic Block, and if Gutenberg is inactive, classic Editor. In each test the visual and text mode work on the classic editor. In Gutenberg, the visible quicktags are existent.

image

cargeo commented 3 years ago

Tested in fresh WP 5.6 install: It’s visible in Gutenberg Classic Editor block, but not in Classic Editor when Gutenberg is disabled (Classic Editor plugin).

See Console screenshot.

macOS 11.1 Chrome 88

Screenshot-WP5 6-AddQuicktag-Console
bueltge commented 3 years ago

I tested again with the Classic Editor Plugin to remove Gutenberg. Text mode works: image

Visual Mode works also, however, I see problems on the settings page to select an icon for a button. image

Do you have more hints, have you an error inside the console? Is your screenshot above on the yellow line a problem?

cargeo commented 3 years ago

The yellow line in the console is not an error, just the only thing I noticed.

In text mode the AddQuicktag dropdown is also not visible, but the button is (see „Test“):

Screenshot 2021-01-22 at 9 57 47 AM

Maybe its related to the WP jQuery version. When using the legacy jQuery version (jQuery Migrate Helper plugin) everything works fine.

bueltge commented 3 years ago

I use a default WP installation, but WP 5.7-alpha, Development version. Maybe I will try them in WP 5.6 Stable.

maryannk commented 3 years ago

I am also having this issue since updating to 5.6. I have Classic Editor running with classic as the default but allowing users to switch editors (switching this to not allowing users to switch editors had no effect). There is no Quicktags dropdown and no quicktag buttons are showing on the text tab.

Edit_Post_‹_Foodie_Dev_—_WordPress

I tried installing jQuery Migrate but it didn't help. I'm happy to provide console screenshots if you tell me what to look for.

maryannk commented 3 years ago

Update - this now seems to be working. When I was testing things, the custom quicktags got deleted (no idea how as I didn't deactivate or delete the quicktags plugin), but now that I have jquery migrate installed, readded the quicktags, and cleared the cache, the drop down is once again appearing in the editor.

fenepedia commented 3 years ago

I have the same issue. Very strange is that it works on my computer and not on the computer of my client. After clearing the cache, the bar was displayed a short period of time and then suddenly disappeared again.

So far, I could not reproduce the behavior on my own computer and browser.

fenepedia commented 3 years ago

I could reproduce the problem with my mac and safari.

I add some text to the post and hit "save". After finishing the saving-process the AddQuicktag dropdown disappeared.

To recover the AddQuicktag dropdown I opened the safari developer-console and cleared the cache. As long as I leave the developer-console opened, there is no problem. After closing the developer-console and save the post again, the AddQuicktag dropdown disappeared.

screen-20210219_tW3hltfb

maryannk commented 3 years ago

I can confirm this same behavior. Since posting that the dropdown was back, it has disappeared and reappeared at different times when saving changes. I am using a MacBook Pro running Catalina and have tested the behavior in both Chrome and Firefox.

bueltge commented 3 years ago

Thanks for these tests and helping notes about the behavior! I think I will fix the jQuery topic at first so that it runs in the current version of jQuery inside the WP core, version 3.5. After that, I will look for problems.

fenepedia commented 3 years ago

@bueltge Do you have a timeline when you could fix this problem?

bueltge commented 3 years ago

Hello at all. Sorry for waiting for feedback or an answer from my side, but the time is small and the task too much for me. However, for now there is an update inside the master branch. It would be great if you help me to test this first update, version 2.6.0-dev to find problems or give me the feedback that it works. The current update is only on the JavaScript side for the jQuery update of the WP core. I will also invest time to maintain the php code. I mean it is not necessary for the functionality, only for the maintenance, and maybe I will also check them for modern php version, like php 7.4 or 8.

So please download (https://github.com/bueltge/addquicktag/archive/refs/heads/master.zip) the master, upload in your plugin directory and activate it for testing. Deactivate your current version for testing.

cargeo commented 3 years ago

I'm experiencing the same issue in 2.6.0-dev. No reliable AddQuicktag dropdown in editor. It's there when initially adding a new classic block, but it's gone after reload (like in #49)

The icons on settings page are working now.

fenepedia commented 3 years ago

Sorry for my late replay. With version 2.6.0-dev the problem still exists. It is the same problem as written in comment https://github.com/bueltge/addquicktag/issues/48#issuecomment-781998538

bueltge commented 3 years ago

I update also the TinyMCE plugin to add the select box inside the classic editor for now. I tested in several install and can't find any problems. Please test again with the current master of this repository. Thanks!

cargeo commented 3 years ago

Latest version of 2.6.0-dev works! AddQuicktag dropdown is back in editor toolbar. Thank you 🙏

fenepedia commented 3 years ago

Yes, I can confirm this. Latest dev works!

bueltge commented 3 years ago

I add several changes to the code. So please would test it again and send your feedback here. After that, I will release this result on wp.org. Thanks a lot.

cargeo commented 3 years ago

I tried your latest 2.6.0-dev: AddQuicktag dropdown is missing again.

bueltge commented 3 years ago

What, I will test also again, but hope also for the test from @fenepedia I have no changes on the javascript of the plugin, only here and their maintenance in the PHP files.

bueltge commented 3 years ago

After several tests from different peoples, I release now the new stable version 2.6.0 Thanks, @cargeo, and @fenepedia for your helping hands! ❤️

fenepedia commented 3 years ago

Das Problem tritt gerade bei einer Installation erneut auf. Ich kann den Fehler allerdings bisher selbst nicht reproduzieren. Das Problem besteht nur bei einer Kundin. Version: 2.6.1 Wordpress: 5.8

Hast sonst noch jemand das Problem?

bueltge commented 3 years ago

Cache hast du deaktiviert? Fehler in der Console des Browsers?

fenepedia commented 3 years ago

Hallo Frank, das Problem hat sich erledigt. Kunde hat versehentlich die Werkzeugleiste ausgeblendet…

bueltge commented 3 years ago

Danke für die Rückmeldung.