bueltge / wordpress-admin-style

This plugin reference elements from wp-admin in an overview with the necessary markup and CSS classes to help you to develop WordPress compliant.
http://wpengineer.com/2226/new-plugin-to-style-your-plugin-on-wordpress-admin-with-default-styles/
GNU General Public License v2.0
960 stars 124 forks source link

I miss you having a direct GitHub update feature #9

Closed brasofilo closed 11 years ago

brasofilo commented 11 years ago

Like I'm doing here, using Yahnis' Plugin Update Checker.

The jQuery UI is awesome :+1:

bueltge commented 11 years ago

Yes, you have right. I find currently no time for this; maybe a pull request. I haven't a solution in a other plugin from my plugins, only in a theme.

brasofilo commented 11 years ago

Ok, I did a pull request. Tested everything in my fork. And, before doing the pull, changed the URL to point to your repo. In theory, it's ready to launch ;)

After it, I ended up creating a clean version of YahnisElsts' updater without the debug files. Maybe should I modify my fork and pull again?

bueltge commented 11 years ago

Thanks again here.

bueltge commented 11 years ago

I have update the json with version 0.1.1, the current last version. Maybe it works and we have a updater via github. Thanks

brasofilo commented 11 years ago

Installed 0.1.1 -> changed the version to a lower value -> update available -> update successful Bravo!

bueltge commented 11 years ago

Bravo to you! :+1: for your help Why lower 0.1.1 is higher as 0.0.7, or im missunderstanding?

brasofilo commented 11 years ago

Let's not start a war of thanks, your WP Admin Style is top notch reference when building admin pages :hand:

I was describing a test. Install this new version, go to plugin-editor.php and lower the version. The new version available prompts out, update, success!

bueltge commented 11 years ago

Fine, but is this the best words in my Bueltgian English.

brasofilo commented 11 years ago

I think it goes like thanks for thanking, I'm also thankful :smiley:

bueltge commented 11 years ago

The pull request is the best on this platform, before github was the open source coding more static, now is it possible to create better source and solutions form different people and this why I love github. Your pull reuest was also a good example for my love to github.