buerokratt / Common-Services

Bürokratt Common Services
MIT License
0 stars 9 forks source link

Business register (Äriregister) service #31

Open rasmusei opened 3 months ago

rasmusei commented 3 months ago

AS A Service manager I WANT TO have Business register service available in Bürokratt SO THAT I can get information from Business register about businesses

Acceptance Criteria

[!NOTE] Added 01.10.2024

Information about API: https://avaandmed.ariregister.rik.ee/et/ariregistri-avaandmete-api/api-teenuste-tutvustus

[!NOTE] Added 25.09.2024

[!NOTE] Added 26.09.2024

RayDNoper commented 3 months ago

Endpoints in XTR v3:

XTR v3 can currently be accessed in dev environment via local network http://192.168.42.65:9020

ValterAro commented 2 months ago

There needs to be some modifications done to the current pull request (https://github.com/buerokratt/Common-Services/pull/55) in order to get it to work in the service flow. The main issue is with the hbs files. The currently expected format for the hbs files looks like this: https://github.com/buerokratt/Buerokratt-DSL/blob/test-tmp-6/DataMapper/v1/Common-Services/hbs/get_employees_with_code.handlebars

{
    "employees": [
    {{#each hits}}
            {
              "text": "{{ _source.workers }} inimest töötab firmas {{ _source.name }}",
              "result": "{{ _source.name }}"
            }{{#unless @last}},{{/unless}}
    {{/each}}
    ]
}

and in the proposed implementation the hbs files look like this: https://github.com/buerokratt/Common-Services/pull/55/files#diff-e159e3e428f31fd772b1f2b960e28296fc4256a19ed8124c3cc370abe23736c7

{
    "ariregistri_kood": {{ keha.ariregistri_kood }},
    "nimi": {{ keha.nimi }},
    "sidevahendid": [
    {{#each keha.yldandmed.sidevahendid.item }}
        {
            "liik": {{ liik }},
            "sisu": {{ sisu }}
        }
    {{/each}}
    ]
}
joonasroosalung commented 1 month ago

Updated here https://github.com/buerokratt/Common-Services/pull/58

ValterAro commented 1 month ago

I will make a pull request for the chatbot repo dev branch once it has been updated to the latest version. Also The common-services repo PR is this https://github.com/buerokratt/Common-Services/pull/57 .

ValterAro commented 1 month ago

The changes to chatbot repository are here https://github.com/buerokratt/Buerokratt-Chatbot/pull/834

turnerrainer commented 1 week ago

Tested, but output needs further processing.

turnerrainer commented 1 day ago

Blocked as the following AC is not fulfilled: