Cross: PR policies - Githubissues

buerokratt / POC-DMR.Cross-functional-requirements

Cross-functional requirements to take into account when developing or planning to develop Bürokratt's custom base components

MIT License

1 stars 1 forks source link

Cross: PR policies #24

Closed shelabd closed 2 years ago

shelabd commented 2 years ago

AS A Developer I WANT TO implement Pull Request policies which prevent unreviewed code from being committed to the main branch SO THAT we can ensure that only agreed upon changes are committed.

[ ] modify the Github subscription to allow for PR policies to be implemented
[ ] Add this policy to the CentOps repo(s).
[ ] Output: document describing PR policies

turnerrainer commented 2 years ago

Discussed it internally and we`ll at first proceed with anyone having a right to merge to main branch.

martinkearn commented 2 years ago

@turnerrainer / @keijoraamat I believe this task is done now isn't it?

turnerrainer commented 2 years ago

@turnerrainer / @keijoraamat I believe this task is done now isn't it?

Yes, but AC changed. We won't change our subscription and will continue with just 2 approvals to pull requests.

martinkearn commented 2 years ago

Closing this as it has been addressed