buerokratt / Service-Module

0 stars 11 forks source link

Add a new state to the Service #191

Open PaulaMerle opened 8 months ago

PaulaMerle commented 8 months ago

AS A Service Manager I WANT TO have new state for the Service - READY SO THAT it would represent the Services that are ready but not yet associated with an intent or not activated

Related to the task https://github.com/buerokratt/Service-Module/issues/41 Take into account https://github.com/buerokratt/Service-Module/issues/195

Acceptance criteria

1AhmedYasser commented 7 months ago

blocked waiting for #196

ValterAro commented 7 months ago

Short summary: Something seems to have broken the ability to see the list of services. Can not see the change until this is fixed. Pic:

Image

1AhmedYasser commented 7 months ago

@ValterAro Working on local, checked it on dev environment with Varmo, and found the problem in services_db, will work on a fix for it with Alar on dev environment

1AhmedYasser commented 7 months ago

@ValterAro its now fixed, please recheck again

ValterAro commented 7 months ago

The last AC can not be currently tested as per this comment (https://github.com/buerokratt/Service-Module/issues/196#issuecomment-1978692236). Setting this currently blocked until an intent can be turned into a serivce.

PaulaMerle commented 6 months ago

@1AhmedYasser State Ready has been created. Cannot test the third AC about the state change logic, since currently not yet possible to complete the process of connecting service to an intent (after connecting the process will remain "pending").

ValterAro commented 6 months ago

Current state: Short summary: When trying to add an intent to a service in the Service module then I can request to add an intent to a service, but I can not add a service to an intent or accept the request. Waiting for the issue (https://github.com/orgs/buerokratt/projects/47/views/35?pane=issue&itemId=49548120) until this can be tested Expected result: You should be able to connect the service with an intent Current result: There is no way to accept the request to connect the intent with a service from the training module side. How to reproduce: Go to https://admin.dev.buerokratt.ee/training/training/intents and create a new intent that you plan to connect with a service. Then Go to service module and create a service and then change the state from draft to ready and then press again to connect to a service. Then select the created intent to connect. Then go to Training module side and try to accept the request to connect the intent to the service. Pic:

Image

Image

ValterAro commented 6 months ago

The latest deploy seems to have fixed it. It is working as intended.