buerokratt / Service-Module

0 stars 11 forks source link

Service Module Creating Service Flow Page #20

Closed SigritSiht closed 8 months ago

SigritSiht commented 2 years ago

AS AN Administrative User I WANT TO pick various elements previously created or predefined (query connections, final utterance, user input/output fields, TARA, SiGA etc) SO THAT I CAN assemble the service flow

This issue is to finalize a Service with the input provided by https://github.com/buerokratt/Service-Module/issues/12

~Use https://xd.adobe.com/view/cb1ca0df-2dea-4432-a05d-bb75db6e2e5f-9e4f as GUI reference instead of the images added in comments~

Acceptance Criteria

GUI

DSL

Comment: The return section of the Ruuter DSL of a created service has to be manipulatable via GUI by adding static text and any number of output in any order from previous steps of the same Ruuter DSL.

ValterAro commented 9 months ago

Short summary: When adding the Client input step to the service flow, then this step does not have the options it had previously. There should be an option to make it a yes/no input and some additional things. Expected result: You should be given options to configure the Client input Real result: the Setup for client input is empty How to reproduce: login and go to https://admin.dev.buerokratt.ee/services/overview . Then create a new service and at the Service flow creation try to add Client input step and try to do edit it. Pic: image

1AhmedYasser commented 9 months ago

Short summary: When adding the Client input step to the service flow, then this step does not have the options it had previously. There should be an option to make it a yes/no input and some additional things. Expected result: You should be given options to configure the Client input Real result: the Setup for client input is empty How to reproduce: login and go to https://admin.dev.buerokratt.ee/services/overview . Then create a new service and at the Service flow creation try to add Client input step and try to do edit it. Pic: image

is this related to https://github.com/buerokratt/Service-Module/issues/182#issuecomment-1920778454 ? does this still persists ?

ValterAro commented 9 months ago

@1AhmedYasser I think it is separate from #182 . There used to be a yes/no option for this whether it is a yes no question with a text box where to write the question. Pic from figma:

Image

ValterAro commented 8 months ago

Seems to work as intended

ValterAro commented 8 months ago

Fix for the Response not showing when checking the JSON request. https://github.com/buerokratt/Service-Module/pull/212

ValterAro commented 8 months ago

Short summary: When creating a service flow and using the element for client input then there is no option to add the next element Real result: You can not add a element after the client input element Expected result: Only the End conversation and send to csa should be terminating elements How to reproduce: login and go to https://admin.dev.buerokratt.ee/services/overview , then try to create or edit a service and in the service flow step add a client input. Additional info: Also there should be two paths out when the option is for a Yes/NO question. Pic:

Image

ValterAro commented 8 months ago

Short summary: You get an error when trying to save a service flow that has a client input in it. Tried with "yes/no" question and the rule based approach for the client input expected result: You should be able to save the service flow with the client input element How to reproduce: login and try to create a new service. Then at the third step add a client input and try to save the service flow. You will see an error popup. Pic:

Image