buerokratt / Training-Module

MIT License
2 stars 21 forks source link

REST service to delete an existing Rasa form #86

Open turnerrainer opened 1 year ago

turnerrainer commented 1 year ago

AS AN Architect I WANT to have a REST service to delete an existing Rasa form SO THAT there wouldn't be duplicate services for it

Acceptance Criteria

Temporary list of endpoints - https://github.com/buerokratt/Buerokratt-onboarding/issues/8 Proto to add new Rasa forms

Example

Initial input

forms:
  custom_fallback_form:
    required_slots:
        - affirm_deny
  direct_to_customer_support_form:
    required_slots:
        - affirm_deny

Output after a request to delete custom_fallback_form

forms:
  direct_to_customer_support_form:
    required_slots:
        - affirm_deny
RaulAltmae commented 1 year ago

sample input for /rasa/forms/delete

{
  "form_name": "custom_fallback_form"
}
turnerrainer commented 1 year ago

@RaulAltmae please link this issue with an appropriate pull request.

RaulAltmae commented 1 year ago

Pull request https://github.com/buerokratt/Training-Module/pull/167

ExiRain commented 9 months ago

Pull request with new changes.

ValterAro commented 9 months ago

Short summary: unable to delete a form even though it says that Form deleted. If I check the request response then it says "Can't find form to delete." Expected result: the form should be deleted if you select yes on the notification and it is not forbidden Real result: there is a notification saying that the form is deleted, but it is still there How to reproduce: login and go to https://admin.dev.buerokratt.ee/training/training/forms , then try to delete the first form in the list. Pic:

Image

ValterAro commented 9 months ago

Seems to work as intended!