search

buerokratt / Training-Module

MIT License
2 stars 16 forks source link

REST service to delete an existing Rasa response #94

Open turnerrainer opened 1 year ago

turnerrainer commented 1 year ago

AS AN Architect I WANT to have a REST service to delete an existing Rasa response SO THAT there wouldn't be duplicate services for it

Acceptance Criteria

Temporary list of endpoints - https://github.com/buerokratt/Buerokratt-onboarding/issues/8 Proto to add new Rasa forms

Example

Input domain.yml before deleting a specified story

responses:
  utter_andmekaitse_küsimused:
  - text: "kõik on kaitstud"

  utter_fallback_kontroll:
  - text: "Jäi arusaamatuks, kas soovisite, et suunan edasi?"

  utter_mille_kohta_küsimus_käis:
  - text: "Kas küsimus käis selle teema kohta: {intent}? (Jah/Ei)"

Output after a request to delete utter_fallback_kontroll

responses:
  utter_andmekaitse_küsimused:
  - text: "kõik on kaitstud"

  utter_mille_kohta_küsimus_käis:
  - text: "Kas küsimus käis selle teema kohta: {intent}? (Jah/Ei)"
RaulAltmae commented 1 year ago

sample input for /rasa/responses/delete

{
  "response_name": "utter_common_teenus_ilm"
}
turnerrainer commented 1 year ago

@RaulAltmae please link this issue with an appropriate pull request.

RaulAltmae commented 1 year ago

Pull request https://github.com/buerokratt/Training-Module/pull/170

Kristjan259 commented 8 months ago

When I press delete nothing happens and I don't see the endpoint being called.

KasparMinn commented 7 months ago

PRs for this issue:

https://github.com/buerokratt/Training-Module/pull/282 https://github.com/buerokratt/Training-Module/pull/316

My PR's comment:

This PR changes the functionality of the responses page slightly to fetch correct information from OpenSearch as well as correctly establish the three different searches for Rules.

ValterAro commented 7 months ago

The delete service is currently not working and throws a 300 error for the POST request to https://ruuter.dev.buerokratt.ee/training/rasa/responses/delete

ValterAro commented 5 months ago

Short summary: Tried to delete a response and get a notification that the response was deleted, but it is still there in the list even after a page refresh. Expected result: the response should be actually deleted Real result: the response is still there after trying to delete it How to reproduce: login and go to https://admin.dev.buerokratt.ee/training/training/responses , then try to delete for example utter_tsettest or any of the other responses. Pic: image

turnerrainer commented 4 months ago

@KasparMinn: closely related to #99

KasparMinn commented 4 months ago

PR: https://github.com/buerokratt/Training-Module/pull/402

Kristjan259 commented 4 months ago

When I open the page I get 500 - internal server error

Image

KasparMinn commented 4 months ago

PR: https://github.com/buerokratt/Training-Module/pull/405

ValterAro commented 4 months ago

Waiting for the ability to add a response which seems to have broken recently, before testing can proceed. See this issue https://github.com/orgs/buerokratt/projects/47/views/35?pane=issue&itemId=41323673 Setting the label as Blocked in the meanwhile.

Kristjan259 commented 4 months ago

Summary of the bug: It does now renew GUI when a response is deleted so you have to manually refresh page when you delete something

Kristjan259 commented 4 months ago

BUG: When I try to save the utterance with some content, it does not add the content later.

Image Image

ExiRain commented 3 months ago

Fixed bug(response text was not provided) Fixed unreported bug when edit -> save without input will result an empty value response Pull request

ValterAro commented 3 months ago

Short summary: the responses page does not load correctly. Issue also written here https://github.com/buerokratt/Training-Module/issues/13#issuecomment-2063636418

1AhmedYasser commented 1 month ago

Working On local, will have to check it on test