search

buettner / private-prefetch-proxy

Proposal to use a CONNECT proxy to obfuscate the user IP address for privacy-enhanced prefetching.
32 stars 6 forks source link

traffic advice: allow servers to specify a fraction #27

Closed jeremyroman closed 2 years ago

jeremyroman commented 2 years ago

@domenic @buettner PTAL? This more or less just codifies the "fraction X means do only X of the stuff", since from what I've heard it seems that that approach has served us well so far.

I've made it so that it doesn't override "disallowed" (you need to pass the disallowed check and the fraction check). This is slightly different from how the Google EAP thing behaved -- it was overriding it on the basis that explicitly saying you wanted something for the EAP was more important than whatever else you were saying. This seems more natural in the long term.

jeremyroman commented 2 years ago

(build fails because #26 hasn't landed yet -- and I haven't figured out how to do dependent pull requests on GitHub, if it's even possible)

buettner commented 2 years ago

This looks good to me. I think the fractional drop is all we need, and +1 to checking for disallow.