search

bufanliu / apparat

Automatically exported from code.google.com/p/apparat
0 stars 0 forks source link

Reducer seems to strip the SWF Metadata tag but forgets to off the HasMetadata flag in FileAttributes #16

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
#What steps will reproduce the problem?
1. A SWF with metadata, mxmlc by default adds some
2. Run the swf through reducer 
3. Various Dump utilities like dump abc fail on this swf ..complaining that 
HasMetadata is set but 
there is no metadata 

#What is the expected output? What do you see instead?
Reducer should off the HasMetadata flag in the file attributes tag, dump should 
succeed on 
reduced SWFs

Thank you,
Mrinal

Original issue reported on code.google.com by mrinal.wadhwa on 28 May 2010 at 5:25

GoogleCodeExporter commented 9 years ago 
Interestingly enough, the SWF spec states that hasMetadata must be turned off 
in the 
FlieAttributes tag if no Metadata tag is present but the Flash Player never 
checks 
this.

Will fix it by setting hasMetadata to false. Will also remove the check to 
mimic the 
Flash Player behaviour.

Original comment by joaebert on 28 May 2010 at 9:09

GoogleCodeExporter commented 9 years ago 
@joa Yes i have seen that on haxe produced swf and forget to tell you

Original comment by leclech.patrick on 28 May 2010 at 10:47

GoogleCodeExporter commented 9 years ago 
Yeah, I noticed as well, the spec is pretty clear about it .. but the player 
doesn't care.
Looking forward to the fix.

Thank you

Original comment by mrinal.wadhwa on 28 May 2010 at 4:05

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision 921564be60.

Original comment by joaebert on 28 May 2010 at 4:26

GoogleCodeExporter commented 9 years ago 
Sorry, the now I understand the issue correct. Well "dump" is no longer 
supported -- a 
new version with ABC/UML export is already ready though. Just need to write a 
launcher 
tool for it.

The Apparat Scala version does in fact no checks on the hasMetadata already. 
That is 
why I never had any issue. In order to fix your problem and to create correct 
files I 
set now simply the metadata flag to false in reducer. Fixed in changeset 
921564be60.

Original comment by joaebert on 28 May 2010 at 4:26

GoogleCodeExporter commented 9 years ago 
A version for Scala 2.8 RC3 is now available: 
http://code.google.com/p/apparat/downloads/detail?name=apparat.zip

Original comment by joaebert on 28 May 2010 at 4:35

GoogleCodeExporter commented 9 years ago 
Thanks Joa, just tried the new release worked perfect.
Dump now works with reduced swfs now as well ... looking forward to the scala 
version.

Thank you for sharing all your great work.

Original comment by mrinal.wadhwa on 29 May 2010 at 11:27