Closed berksean closed 1 year ago
Note - Several android specific unit tests failed (suffixed with android library plugin
and kotlin android plugin
) indicating that the ANDROID_HOME
environment variable was unset. I imagine this is because I don't have android studio installed/set up. If there some instructions on what tools are necessary somewhere, I can verify those tests are passing as well.
Random question that is unrelated -- If there are other potential issues/feature requests, do you/buf prefer starting a conversation in slack, as an issue, or some other means?
Two things that are in my queue:
do you/buf prefer starting a conversation in slack
I'm happy with an issue since that's what I get notified about and it's a better public record. However I am not on the Buf team and they may have a different preference. cc @buildbreaker
gradle's stale outputs detection will delete the contents of the bufbuild directory
Sounds nasty. I started some work a while ago on output and input declarations but never gave it a ton of attention. It's effectively lost, so there's no need to worry about duplicated work if you decide to take it on. If you achieve reproduction with a minimal project, please file an issue!
handle reverts in CICD
I have set up a "workflow" in my organization where you disable the Buf check with checkSchemaAgainstLatestRelease = false
for one minimal PR with just the breaking change, and then re-enable it in the very next PR. We have tooling that looks for that line in the buildscript and if it sees checkSchemaAgainstLatestRelease = false
(or if it is absent), the only PR it allows to follow is one that re-enables the check so that no other breaking changes can sneak through. This check is tightly coupled to our build system, so I didn't write it into the plugin. I'm open to exploring a solution here.
Addresses issue 132
Fix buf tasks behavior with more recent versions of the
protobuf-gradle-plugin
. With version0.9.3
(and possibly all0.9.*
versions), the buf plugin tasks no longer work whenprotobuf
dependencies are used (as described in the issue). This change filters the hard-coded "extracted" directories from the list of proto source directories set by the protobuf gradle plugin.Tested by:
0.9.3
.