Prevent the error when explicitly specifying default buf gen temlate file path

bufbuild / buf-gradle-plugin

Gradle plugin for the Buf CLI

Apache License 2.0

46 stars 13 forks source link

Prevent the error when explicitly specifying default buf gen temlate file path #199

Closed un1024 closed 1 month ago

un1024 commented 3 months ago

Backgroud: I encountered the following error.

Buf gen template file specified in the project directory as well as with templateFileLocation; pick one.

But I have just one template file {rootDir}/buf.gen.yaml. I didn't understand the reason for the error until I read the source code.

I think it's natural to want to specify the file path explicitly. Therefore how about making this trivial fix to prevent confusion?

Thanks.

CLAassistant commented 3 months ago

All committers have signed the CLA.

drice-buf commented 1 month ago

@un1024 Please let me know in the next day or so if you still want to be involved with this PR, otherwise I will go ahead and push my change to the branch and get the PR merged.

un1024 commented 1 month ago

@drice-buf Sorry, I've forgotten this Pull Request and am late... 🙇 I have fixed and pushed for your comments. Ofcourse I am fine with you to change it there.(If necessary, you can discard my pull request if you like, too.) Thank you for your time.

drice-buf commented 1 month ago

@un1024 thanks for the PR and for bringing it up to date quickly.