search

bufbuild / buf-gradle-plugin

Gradle plugin for the Buf CLI
Apache License 2.0
46 stars 13 forks source link

Upgrade to Buf CLI version 1.35.1 #213

Closed drice-buf closed 1 month ago

drice-buf commented 1 month ago

All tests pass now. A couple of tests now specify an older Buf version.

Older comment:

This currently disables two tests in BreakingWithProtobufGradleTest:

I'm still trying to see if I can reasonably get them to pass.

drice-buf commented 1 month ago

@andrewparmet I was able to get almost everything to pass with fairly minimal changes:

  1. Specify Buf version 1.31.0 for two tests that use buf.yaml alongside bufwork.yaml:
    • BreakingWithWorkspaceTest/normally_breaking_schema_with_an_ignore
    • GenerateWithWorkspaceTest/buf_generate_with_default_template_file_path_explicitly_specifying
  2. When generating a virtual workspace for the Protofbuf plugin, generate a v2 buf.yaml file instead of buf.work.yaml
  3. Temporarily ignore the test BreakingWithProtobufGradleTest/normally_breaking_schema_with_an_ignore. This test case runs into the json-vs-json buf breaking issue.

This should allow things to move forward. Next steps are to get the ignored test to pass and do add additional test coverage for cases that combine v2 buf.yaml files with usage of the Protofbuf plugin.

drice-buf commented 1 month ago

I think there are still some test behaviors that need to be nailed down, but I think this is a reasonable milestone with all existing tests passing and minimal behavior changes.

drice-buf commented 1 month ago

For some reason a few tests were failing depending on how the Jackson object mapper was initialized. I will look into it further, but for now tests are all passing in CI.