bufbuild / buf

The best way of working with Protocol Buffers.
https://buf.build
Apache License 2.0
9.08k stars 276 forks source link

invalid memory address or nil pointer dereference when running buf mod update #1673

Closed AndreasBergmeier6176 closed 1 year ago

AndreasBergmeier6176 commented 1 year ago

With buf.yaml:

version: v1
name: github.com/private/foo
deps:
- buf.build/envoyproxy/envoy
breaking:
  use:
  - FILE
lint:
  use:
  - DEFAULT

Output is:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xac203e]

goroutine 23 [running]:
github.com/bufbuild/connect-go.(*connectUnaryClientConn).validateResponse(0xc0001cf300, 0xc0000be480)
        github.com/bufbuild/connect-go@v1.1.0/protocol_connect.go:423 +0xafe
github.com/bufbuild/connect-go.(*duplexHTTPCall).makeRequest(0xc00044b780)
        github.com/bufbuild/connect-go@v1.1.0/duplex_http_call.go:257 +0xcc
created by github.com/bufbuild/connect-go.(*duplexHTTPCall).ensureRequestMade.func1
        github.com/bufbuild/connect-go@v1.1.0/duplex_http_call.go:233 +0x5a
joshcarp commented 1 year ago

Hey @AndreasBergmeier6176 Thanks for opening this issue!

The latest dev version of buf has a some updated dependencies that solve this issue, so It should be fixed in the next release

➜  buf git:(main) ✗ buf --version 
1.10.0
➜  buf git:(main) ✗ go install ./cmd/buf 
➜  buf git:(main) ✗ buf mod update
Failure: Not Found
yangzh commented 1 year ago

This issue seems to affect production, may I ask when the fix can be released?

joshcarp commented 1 year ago

Hey @yangzh Fix will be released on Monday

joshcarp commented 1 year ago

Hello, this fix was released in https://github.com/bufbuild/buf/releases/tag/v1.11.0