search

bufbuild / buf

The best way of working with Protocol Buffers.
https://buf.build
Apache License 2.0
9.08k stars 275 forks source link

golint format compatiblity #259

Closed nhatthm closed 3 years ago

nhatthm commented 3 years ago

Hi team,

I'm working on a project that needs to parse the error output of buf. Unfortunately, the output is not supported by (reviewdog](https://github.com/reviewdog/errorformat/tree/master/fmts). However, it's pretty similar to golint:

# golint
FILE:LINE:COLUMN: MESSAGE
# buf
FILE:LINE:COLUMN:MESSAGE

So far from what I researched, not only reviewdog but other tools also support golint and they have a strict check for space before the MESSAGE, it's not optional.

I think it would be better for everyone if we reuse the same format as golint.

Wdyt?

bufdev commented 3 years ago

While written in Golang, buf is not a Golang-specific tool, and FILE:LINE:COLUMN:MESSAGE is a much more widely-used standard from our experience. We don't aim to match this specific Golang linter. Additionally, golint is deprecated. Changing this format would be a breaking change on our part, and we do not want to break users. The right answer here would be to add buf to https://github.com/reviewdog/errorformat/tree/master/fmts