Git inputs cannot reference tags with the ref option

mloesch commented 2 months ago

As far as I understand, git branches and tags are types of git refs (they are stored under .git/refs).

IMO it should therefore be possible to use the ref option as a generic way for referencing commits, branches, and tags.

This is actually stated in the documentation:

Any ref that is a valid input to git checkout is accepted.

However, while git checkout remote-tag is working, buf generate "ssh://git@github.com/path-to-repo.git#ref=remote-tag" is not.

IMO this feature would make parameterizing CI pipelines easier, e.g.:

ssh://git@github.com/path-to-repo.git#ref=develop - build against latest changes on the develop branch
ssh://git@github.com/path-to-repo.git#ref=v1.0.0 - build against a stable release tag

Note: this is also how kubectl kustomize is implementing the refoption:

ref - a git fetch-able ref, typically a branch, tag, or full commit hash (short hashes are not supported)

srikrsna-buf commented 2 months ago

I can reproduce this with:

buf build "https://github.com/bufbuild/buf.git#ref=v1.27.0,subdir=proto"

The same works when I use tag:

buf build "https://github.com/bufbuild/buf.git#tag=v1.27.0,subdir=proto"

Thank you for reporting, we'll look into this.

emcfarlane commented 1 day ago

Fix will go out in the next release.

bufbuild / buf