bufbuild / httplb

Client-side load balancing for net/http
https://pkg.go.dev/github.com/bufbuild/httplb
Apache License 2.0
48 stars 2 forks source link

Make sure all resources are released when Close returns #20

Closed jhump closed 1 year ago

jhump commented 1 year ago

I happened to catch a few bugs while adding this stuff. We still need a lot more tests to suss out other latent bugs in this code. But I did add some assertions to the existing smoke test that verifies that all goroutines are cleaned up after Close.

Resolves TCN-1905 and TCN-1906

linear[bot] commented 1 year ago

TCN-1905 Transport pools need to wait for activity to quiesce before trying to close idle conns

TCN-1906 Main transport needs to wait for everything to be closed