bufbuild / knit-go

Knit standalone gateway and Go embeddable gateway
Apache License 2.0
49 stars 2 forks source link

Remove some signals to make Windows build happy #18

Closed jhump closed 1 year ago

jhump commented 1 year ago

Before we can land #17, we need the release to actually build. The release includes a cross-compile for Windows, which was failing to build because the compiler couldn't resolve the syscall.SIGTSTP, syscall.SIGUSR1, and syscall.SIGUSR2 references.

Instead of adding build tags to only include these signals for non-Windows, it was simpe enough to just leave them out. It's probably okay on Unix if these signals incur the default handler (which would mean unclean termination).

I also added a new make target so that we can verify the release will build as part of CI.