Closed zchee closed 1 year ago
Hi, @zchee, thanks for opening a pull request!
But I'm afraid the existing gci configuration is intentional. The current import grouping (just two groups) is consistent with other bufbuild repos (like bufbuild/buf and bufbuild/connect-go).
@jhump Ah, I see. That's the bufbuild code style. I respect it.
So, I changed PR about all: add import alias for not matched import path and package name
, WDYT?
I think import alias also not bufbuild style. Close.
@zchee, sorry I didn't reply to this. I got pulled into something late last week and have been kind of heads down for a while. I was still considering this pull request. My main concern with merging it is that it won't last very long: as the code is edited and new imports are added, things will change and the aliases may be lost.
I think the intent is completely reasonable. But I also think we need some way to check/enforce it in CI if we want these aliases to be preserved over time. If there's a way to make golangci-lint
enforce it, I'd be receptive to it.
@jhump Nop!
and yes, golangci-lint has importas
linter, which enforce strictly them.
I'll re-open PR with that later, Thanks!
@jhump PTAL
@jhump Thanks!!
@jhump Would you like to send this change to another repository by me?
For code readability.