search

bufbuild / protovalidate-go

Protocol Buffer Validation for Go
https://pkg.go.dev/github.com/bufbuild/protovalidate-go
Apache License 2.0
294 stars 19 forks source link

[BUG] priv error #145

Closed vet1ments closed 2 months ago

vet1ments commented 2 months ago

buf.build/gen/go/bufbuild/protovalidate/protocolbuffers/go v1.34.2-20240717164558-a6c49f84cc0f.2 is ok but buf.build/gen/go/bufbuild/protovalidate/protocolbuffers/go v1.34.2-20240920164238-5a7b106cbb87.2 in this version raise not found "priv.." (i dont know the detail) error

buf.yaml

version: v2
modules:
  - path: proto
lint:
  use:
    - STANDARD
breaking:
  use:
    - FILE
deps:
  - buf.build/bufbuild/protovalidate

buf,gen.yaml

version: v2
managed:
  enabled: true
  override:
    - file_option: go_package_prefix
      value: github.com/vet1ments/grpcoauth/go
  disable:
    - file_option: go_package_prefix
      module: buf.build/bufbuild/protovalidate
plugins:
  - local: protoc-gen-grpclib_python # async stub
    out: python
  - remote: buf.build/protocolbuffers/python:v28.2
    out: python
  - remote: buf.build/protocolbuffers/pyi:v28.2
    out: python
  - remote: buf.build/grpc/python
    out: python
  - remote: buf.build/protocolbuffers/go:v1.34.2
    out: go
    opt: paths=source_relative
  - remote: buf.build/connectrpc/go:latest
    out: go
    opt: paths=source_relative
  - remote: buf.build/grpc/go
    out: go
    opt: paths=source_relative
inputs:
  - directory: proto
jchadwick-buf commented 2 months ago

Sorry about this: it is an unintended consequence of a breaking change that occurred in protovalidate. It's my own oversight, I didn't realize Go would start pulling the latest protovalidate changes before we updated the module in protovalidate-go.

Please stick to using version v1.34.2-20240717164558-a6c49f84cc0f.2 of the gencode for now. We will work on shipping the changes that fix this in https://github.com/bufbuild/protovalidate-go/pull/144 ASAP.

jchadwick-buf commented 2 months ago

We have released protovalidate-go v0.7.0 which will fix this issue. You can update to it using a command similar to go get -u github.com/bufbuild/protovalidate-go. Please note that v0.7.0 contains some breaking changes as well, which may require some code to be updated, though I believe for most users the impact will be fairly minimal.

Please let us know if you have any more issues. I apologize for the unexpected inconsistent state of the modules and will try to coordinate changes better in the future to hopefully prevent this confusing situation.

vet1ments commented 2 months ago

thank you so much for comfirming, All problems are solved