search

bufbuild / vscode-buf

Visual Studio Code integration for Buf.
Apache License 2.0
62 stars 13 forks source link

Support a protobuf language server #343

Open ryanberckmans opened 4 months ago

ryanberckmans commented 4 months ago

Hi, it would be terrific if this package could bundle in a protobuf language server that, for example, supports jumping to a symbol definition in an import file.

Currently, I am using this package for linting and pbkit.vscode-pbkit for the language server. However the pbkit language server isn't working for me, and I'd prefer to remove pbkit and run everything through buf.

How do you jump to proto symbol definition in your editors?

scbizu commented 4 months ago

I am doing the same things but migrate vscode-proto3 to buf , there is a (currently not active) lsp server for buf supporting symbol definition , but currently have no integration in vscode-buf

scbizu commented 4 months ago

You can try my fork , I impl the vscode definition provider via bufls , but it is based on the unstable feature , I prefer not to PR to upstream.

disjukr commented 1 month ago

fyi. https://github.com/pbkit/vscode-pbkit/issues/25#issuecomment-2384698361

bufdev commented 1 month ago

We don't support the above library - we're working on adding LSP support to VSCode here, we'll keep you updated.

scbizu commented 1 month ago

@bufdev The LSP server implementation is better , there are other editors like Zed could integrate it as well , they are also looking for the solutions for protobuf lsp

bufdev commented 1 month ago

We just merged an experimental LSP server via "buf beta lsp", we'll have more details soon, it's still a work in progress.

disjukr commented 1 month ago

@ryanberckmans I've released vscode-pbkit v0.0.8. While you may use vscode-buf later, for now, you can use 'Go to Definition' in vscode-pbkit with the buf v2 configuration. If you were already using v1 or v1beta1 config, it should have been working well.