buff0000n / dojocad

Dojo planner/builder for Warframe
MIT License
28 stars 7 forks source link

Feedback #2

Open buff0000n opened 4 years ago

buff0000n commented 4 years ago

Just a placeholder issue for people to leave feedback

Kisutora commented 4 years ago

Hi hi! Great work so far! :)

Biggest features/tweaks for me that I'd love to see that are not already in the To Do:

Keyboard shortcuts!

Add Room Menu

I think making room selecting more visual would be beneficial. Here's a quick mockup of what I'm thinking of: dojobuilder_concept

buff0000n commented 4 years ago

@Kisutora Thanks for the feedback!

Faster zoom in and out / less zoom level increments.

Not sure what you mean, with my mouse wheel you can already go from min to max zoom in a fraction of a second.

Undo and Redo.

Undo/redo are always really difficult to implement, but I'll put them on the list.

Ability to rotate room while moving it at the same time. Keyboard shortcuts! Hover over categories to reveal room options instead of having to click.

My focus right now is making something that's mobile-friendly. I'm trying to avoid having so many keyboard shortcuts that you need an on-screen cheat sheet, or adding hover functionality that doesn't work on a touch screen.

Ability to turn grid off.

If this is so you can take a screenshot, that's covered by this todo:

Export as PNG

Tracker for prerequisite rooms for Halls, Labs etc.

Covered by todos:

Capacity/Energy tracking Room count constraints, for certain rooms and overall

I think making room selecting more visual would be beneficial.

Covered by todo:

Icons?

Should Observatory be in Interactive category?

What's interactive in it? The arsenal?

Kisutora commented 4 years ago

Not sure what you mean, with my mouse wheel you can already go from min to max zoom in a fraction of a second.

This is what scrolling is for me. Could be my mouse options I guess. giphy image

My focus right now is making something that's mobile-friendly. I'm trying to avoid having so many keyboard shortcuts that you need an on-screen cheat sheet, or adding hover functionality that doesn't work on a touch screen.

Fair enough, I respect that but I do wonder how many are going to design their dojo on mobile. I'm not certainly going to but I'm just one person.

What's interactive in it? The arsenal?

Yes, the arsenal and navigation. :)

buff0000n commented 4 years ago

This is what scrolling is for me.

I see what's going on. Firefox does mousewheel events different from every other browser, because of course they do. Try it now.

I do wonder how many are going to design their dojo on mobile.

"Mobile" also includes things like tablets and iPads.

Yes, the arsenal and navigation. :)

I guess, but I almost never think of the Observatory as anything other than a place for decoration. Pretty much every fully decorated Observatory I've seen has covered up the navigation spots.

yodaxep commented 4 years ago

This is my clan, and obstacle and elbow have a bit of an incorrect collision, since it's all normal in the game. https://buff0000n.github.io/dojocad/?v=2,298,158,0&mz=BYRgNADJ0Q+gTgU2gWgCwA4awMbKmmtAEy47QgBsY4cA9vGCgMzhU1jO4Auq74pHLxbEm-TmSaUiKcfXIgQRcSFgAbXlHRtICZCKaYOcPFJmFj6umbDFqA2MFGyQzlY+ZiA7NVn2ajjLEaFruAOZqTMwQMnJ6UTE2tLAAJgCuCUTMog5CNn62unko0jTUoqTcwGK+7KImAB41NvWwEc0uFbrAAKxgRgU58dktukhgpSVEreMjIxXxpfO2uE0AnLXlATiMBX5QrcAAlkwYoa6FqsdiFp2XuABGTBujgk+yxFhThVzp+VQHIrIT5iC5DHBNc6iTyqOgAQxqOS2XBw71KRmhbUiBQxQOaaxyK1MBUoWCgcDCAGd8dRyfF2C8oKpxugsIyJDhyAVXGSilz+JRyXzmiACdhxgKhczkPwxUz6fYQfKWUYedAuCqsAD1fFWTQ5RIUilmsxmLSAnR3sRgpwzeqgA And keep up to good work, you're doing great! P.S. It's my first time using Github.

buff0000n commented 4 years ago

@yodaxep Yep, confirmed in my dojo. Looks like I need to shave 4m off the width of the Obstacle Course Architect room. Thanks for the report!

buff0000n commented 4 years ago

@yodaxep should be fixed now. Thanks!

WildPenquin commented 4 years ago

Hi!

Just my few suggestions are, mainly to facilitate collaboration:

I've found color coding can be useful to plan priorities i.e. which parts should be build first. However, if one can choose from a large selection of colors (or any RGB value), it could mean anything the user wants ;-)

Thanks anyways for this planner, seems like it has all the most important features and is the most feature-complete planner out there - and also, source available, so others can contribute if they wish!

buff0000n commented 4 years ago

Thanks for the feedback @WildPenquin

  • Annotation by:
  • arbitrary text

Text is a lot harder to deal with consistently in a cross-browser way. It also opens a whole can of formatting worms around font, size, centering, color, also annoying to deal with cross-browser. It sounds like what you really want is Google Docs-style versioning and collaboration, and that's unfortunately way out of my league. I'm not saying never, but not any time soon.

  • automatically by room (newbies don't know what a room is just by it's outline)

Did you know you can select a room and click on it again to see its name and stats?

  • Changing colors of a room (and text)

Unfortunately, arbitrarily tinting a grayscale image to any color is surprisingly hard in HTML5/CSS. I think I have an idea, but it will be a while before I have the bandwidth to try it out.

WildPenquin commented 4 years ago

Did you know you can select a room and click on it again to see its name and stats?

Yes, though I'm not sure I knew while I made my comment, I may have found out only afterwards =)

I understand things can be a bit difficult technically (I'm familiar with programming only superficially, but still get the gist of it). They are just suggestions, anyways. Keep up the good work!

fubaWoW commented 3 years ago

hi there, first at all -> very great work! :)

It would be nice if we could switch on/off to show/hide the floors above/below while in design time because "sometimes" it's very frustrating, especially if you label many rooms.

thanks in advance

adrienne commented 3 years ago

@buff0000n i have a suggestion wrt label colors. Currently they automatically pick up a variant of the room color and add a dark outline, and some combinations can be surprisingly hard to read. Having a separate full color picker for labels seems like overkill, but I think a couple really simple choices would improve things a lot.

First, if you could add a toggle that simply allowed a choice of white vs black outline, that would solve probably 80% of the issues right there.

Also, if you want to improve things more, have a simple selector that would allow you to choose from the following:

buff0000n commented 3 years ago

@adrienne Could you give me some examples of things that are hard to read? Maybe in a dojocad link? I'll see if there's something I can do to automatically pick between black/white for the outline.

buff0000n commented 3 years ago

@adrienne Nevermind, played around and came up with a simple rule to flip to a while outline when the brightness slider is below 25%.

FYI: you already have the ability to put a different color label on top of a room by placing a separate Label object on top of it: https://buff0000n.github.io/dojocad/index.html?v=7,-8,-31,0&mz=BYRgNADJ1SIJwC4QQCyIKyoPoBsCGMRAbAMyIBMEEyA7BmAEQAy+ARgKa6NA

adrienne commented 3 years ago

Oh, i didn't realize there was a label object!

As for the outline -- you probably want to make the change happen at more like 35% brightness, not 25%, just fyi. This is above the threshold but getting hard to read (esp if i made the text smaller) image

adrienne commented 3 years ago

Also @buff0000n do you take pull requests? There's a couple things i'm thinking of cleaning up/adding (like allowing display of the decoration capacity of each room)

buff0000n commented 3 years ago

@adrienne

As for the outline -- you probably want to make the change happen at more like 35% brightness, not 25%, just fyi. This is above the threshold but getting hard to read (esp if i made the text smaller)

Yeah, sure. I'm used to working in a cave so it's easier for me to read than most people.

Also @buff0000n do you take pull requests? There's a couple things i'm thinking of cleaning up/adding (like allowing display of the decoration capacity of each room)

Sure, but if you're thinking if putting that number in the room menu next to energy and capacity then those menus are already almost too wide for mobile.

buff0000n commented 3 years ago

@fubaWoW FYI: I have added something for this: Settings -> Show All Floors -> uncheck.

Allknight96 commented 2 years ago

image Vent Kids bash lab is larger than its tile apparently

Nemirtingas commented 2 years ago

Hi, I've got access to the older rooms and there is a wrong size for the old clan hall. I don't know if you really care about this as no one can build it anymore, but here's the thing: This is our old Dojo first floor image

justawarframeuser commented 1 year ago

Amazing work! Thank you for the amazing app!

I did create my account to report a bug with the new rooms but I might as well express how your app helped my configure my Dojo with ease and test ideas before comiting to anything.

I thought you were using some data from DE to create the rooms but it looks like most of it is testing and guessing in your hands. That is really impressive.

Thank you and stay safe!

x-cessive1992 commented 9 months ago

Hello @buff0000n, great work - DojoCAD is an amazing tool and helped me a lot!

My clan also has some of the discontinued rooms and some things dont quite fit as I hoped (and planned). I just found out that the Oracle (red on the left) does not fit. Not even the Tenno Lab fits there. Only the Ventkids Bash Lab fits on that position. And I guess the Reactor and the Dueling Room on the right side will not fit either.

grafik

So the Old Clan Hall is probably wider than you thought. It would be awesome, if you could adjust it in the DojoCAD. In the Special Note about the Discontinued Rooms you said that you had to guess a lot of the dimensions. I would like to help clarify or test some things to make DojoCAD more accurate.

buff0000n commented 9 months ago

Oh, sorry about that. Yeah, I'm unable to test the old rooms myself so they're all guesses.

Being able to fit a Bash Lab there but not a Tenno Lab is a good data point. That narrows down that bounds to within 3 meters.

I always hesitate asking people to test room boundaries for me, because it involves either (1) managing to clip your way out of the room by placing a transporter right against the ceiling (can you place decorations in these rooms?) and measuring the bounding box from the outside with waypoints Or (2) building something like this

Screen Shot 2023-12-02 at 9 23 23 PM

Which is the only way I know how to narrow down the boundary further.

Also, I just noticed an earlier comment on this ticket above that I missed about pretty much the same thing. They have different results, but their setup is not exactly the same. It may be that the boundary for that room is not a simple box, which makes things very hard to nail down.

x-cessive1992 commented 9 months ago

I am building a cealing-transporter in the old clan hall now and I think I can also do the setup you showed above. Instead of the T-connector, I have an old Cross Connector. Does that still work?

I also added you ingame, if you want to visit and maybe measure some stuff yourself :)

buff0000n commented 9 months ago

@x-cessive1992 Ugh, taking a look at some of the clan halls that are older but not that old, I don't think clipping out is going to help. If the room doesn't have a skybox then there's not going to be anything outside I can visually measure. Probably the best I can do with waypoint measuring is going to be just the interior dimensions.

Instead of the T-connector, I have an old Cross Connector. Does that still work? Yeah, my screenshot should have showed the old cross connector, which is what you used to get the Bash Lab result. One thing I should add is that you don't actually have to build the Observatory in the above screenshot, just see if it's possible to build.

My schedule is pretty unpredictable, but if I see you online then I'll give you a ping. In the meantime, before you build too much stuff, can you give me a DojoCAD link for what your dojo looks like right now? Maybe I can work out a test plan that gives us the most bang for our time.

I really appreciate the effort, but I have to warn you that it's gonna suck. I have a stockpile of plat in my clan vault so I usually do a lot of rushing room builds when I'm testing boundaries.

x-cessive1992 commented 9 months ago

I was able to get out of the Clan Hall. This "T-section" at the bottom of the Clan Hall is wider than the rest.

grafik

And this is the current state of the dojo: https://buff0000n.github.io/dojocad/index.html?v=2.0,-14,120,0&mz=PYCwjANAtAnBBMEAMyJiQVgFxgGzbwGYIAiAGRIH1gBjG6ODeAOg1RXQPx12PKtr1YEABxwUHTDy58K1AE7QALC3hsxqQgoCmCJczWjxaBAHZpPWVRoAPBBgNsmrVGGohEw0w8OREnCyJSORoAZwYIQh82SCRKAHNw4TAwRxM4sIioMBZvdMoQJSznPNiEgBsslNxmUuRKeV1COGy8Wpi0Bt0oDFNoavaTLRA2YWyRJEGygBcQLPglfTq4gBMAV2he6AWljq11yJadqc7gACMsqJrlymnEJUhs3F2TN2nHjBa8F8gtW0P+jBrh03P8en1skCTqCLqZHmAoXUYdANJDgfkaLD4c8Tn8LlBUd8TvAEuF0MQnj96ol+vBsVS4vFKuT+m0bkzafC2R1GWSkBTcCITrzOdBBcLKGCHmhUr5OmDTMQUmlIKC7PAlbKQZK7BgYlrXhVRcq5YzmfyZSrqUkco9COiyjSWVB7RKQN1FZtcjyCro9V63QAzNAW7xWuIgYPZOkQMOm6h0LJKIVsCQhrgyYIAKGs6uiyhTrh1ykIaSgyZcHEo5WAEFwpjLFdT8sUUDjoybmgKAEssjAhXkJNXppsUATvV3yt1-a0XigtOV6M1WXPOuULoQISIJ1WaN0vipBtl6nuqmAB6NECTT2MwIe8i6T-vWRflAhKCsVvMYJMH0UMnYt5KOi5b1LQCBgBC8A-keRRuMAACG2wItsMF-pEkrPikMBpCgJKNCGFIIg69QEdG8KIj6ZFgBgRE4nUWjUbgXzckMXT9LRYqvr87HZJxLokYx3R4IwOFykJ-TMRAMAGjxBFgFEklUm48kYFyJEqboCmjOKSLsdp0CunpqmQJ8VqaWganSbJnTyRaOSlnK+HCTGDlWteI7lo5TgsM2C4AG4lmk8CFkOiZtvmzjNhkQjoA2hhRewCjQO2oils2JLlJ5qXwA20XFr0aSJVW5Rfng-g2W45SBU8qo2YQQA

x-cessive1992 commented 9 months ago

I tried to measure the dimensions using the waypoint. Its not an accurate method but these are my results:

grafik

buff0000n commented 9 months ago

@x-cessive1992 You can stop building hallways there; you're not going to fit an observatory. There's too much stuff in the way.

I think what you've got so far is good enough for this room. According to your room testing, it should be strictly greater than 46m wide and less than or equal to 52m wide. You measured the widest part at 47m, so that checks out. You also measured the length as 65m where my screenshot measurements put it at 64.5m, so that's pretty cool.

Here's your measurements against what I've traced from screenshots: old-hall-test-smaller

I think I'm just going to make it a box that's 52m wide. I prefer to err on the side of caution. False negatives are far less of a problem than false positives.

If you feel like doing me another favor, you can do some testing on the other hall on the floor above. Nothing fancy, just some screenshots of what it allows you to build here:

Screen Shot 2023-12-04 at 1 54 36 PM

And if you feel like building yet more temporary hallways, what you can build here:

Screen Shot 2023-12-04 at 1 55 31 PM

And here:

Screen Shot 2023-12-04 at 1 56 03 PM

I just need screenshots of the Add Room screen showing what's allowed and what's not, you don't have type out a list.

Thanks!

x-cessive1992 commented 9 months ago

@buff0000n I think we can do better than just a 52m wide box. I believe my first assumption, that the dueling room would not fit, is wrong. I think it will fit, because the wider area is only in the bottom half of the old clan hall. And I think DojoCAD should be as accurate as we can make it, to allow others to plan in the best way possible.

Testing this only requires me to delete the temporary Reactors that I built to rearrange stuff on the main floor, so that is not a problem. (Edit: And some rooms that I planned to delete anyway) grafik

I think it might then also be interesting to test this: grafik

And this: grafik

What do you think - are those tests useful?

Your suggested tests for the other clan hall are also no problem.

buff0000n commented 9 months ago

@x-cessive1992 You're planning on deleting that hall and all your labs, too?

I would start with just seeing what will fit here

Screen Shot 2023-12-04 at 2 28 24 PM
x-cessive1992 commented 9 months ago

Yes, thats better. I can give you the result in 2h. I just saw that I cant speed up the destruction, but I will speed up the T-Connector, once the destruction is done. If you have time in 2h, you could join me ingame and have a look at the rooms yourself

Edit: I am gonna visit my familiy for a week starting tomorrow, so further tests will have to wait

x-cessive1992 commented 9 months ago

Hey @buff0000n,

Yes, I plan to delete the hall and the labs. I am rebuilding almost the entire Dojo except for the legacy rooms and the 2nd floor.

I made a mistake on the 2nd floor. The Infested Chambers are rotated differently. I am rebuilding the left one to do your requested tests there. But the current rotation is also useful, because there are some room placements that DojoCAD would allow, but cant actually be build. grafik

DojoCAD is wrong about Small Gardens: grafik

DojoCAD is wrong about the Chem Lab: grafik

DojoCAD is right about the halls: grafik

DojoCAD is wrong about the Reactor: grafik

DojoCAD is wrong about the Cross Connector and the Extended Straight Hallway: grafik

DojoCAD is wrong about Courtiers Bliss and the Dueling Room grafik

I couldnt properly test the other position yet, because I forgot to delete the rooms on the bottom side.

buff0000n commented 9 months ago

@x-cessive1992 Okay, that narrows it down to >64m but <=70m wide. I think that's pretty good, thanks for the details.

If you're interesting in testing if there are notches in the corners of the large halls' bounding box, like there are with the "newer" basic clan hall, then I'm having a hard time coming up with something efficient with your setup. They best I got is this piece of shit

Screen Shot 2023-12-04 at 10 12 16 PM
x-cessive1992 commented 9 months ago

Looking at this now: grafik

Nothing unusual with the gardens: grafik

The Orokin Lab does not fit, but i guess that is no surprise now. grafik

No news here: grafik

The Reactor DOES fit on the top side. It only does not fit on the bottom side (see further below) grafik

No news here: grafik

As I said before, my assumption that the Dueling Room wouldnt work was wrong. grafik

Duviri Cave (and similar halls) do not work like this: grafik

The fact that Harbingers Pass does not work might be interesting (and that Clan Tier Barrack do work): grafik

Now properly looking at the bottom again: grafik

Only the Ventkids Lab and the Connectors (except Cross) work - NOTHING else: grafik grafik

buff0000n commented 9 months ago

@x-cessive1992

my assumption that the Dueling Room wouldnt work was wrong.

Yeah, the dueling room is actually slightly, very slightly, smaller than the reactor.

So far the determining factor on the length of the upper notch is between the Barracks at 33.75m and Harbinger's Pass at 45.75m. The .75 comes from the fact that the old cross connector extends 2.25m further than the new connectors.

That's a pretty big range, you could try testing this to narrow it down further:

Screen Shot 2023-12-05 at 1 16 17 PM
buff0000n commented 9 months ago

We really should have started a new issue for this...

buff0000n commented 9 months ago

@x-cessive1992 Here's what the updated Old Hall bounds look like so far:

Screen Shot 2023-12-05 at 3 41 15 PM

And the Old Grand Hall, just a little bit wider:

Screen Shot 2023-12-05 at 3 47 24 PM

If you're interested in seeing whether there's another notch at the bottom of the Old Hall bounds, then you're going to have to do something like this:

Screen Shot 2023-12-05 at 3 38 32 PM

If a small hallway fits there then there's a notch. If anything else fits there then there are also notches in the Old Cross Connector's bounds.

Also, I'm curious whether Courtier's Bliss fits on the right side of the Old Hall. It's slightly wider on one side than the other.

Screen Shot 2023-12-05 at 3 40 55 PM

Thanks so much for your help so far!

Dilgins commented 8 months ago

A feature I'd like to suggest when it comes to spawn points is the ability to universally set any rooms as spawn points, instead of just Clan Hall.

For example, my clan's dry dock has a spawn point set there

buff0000n commented 8 months ago

@Dilgins The Arrival Gate and Spawn Room are two different things. Even if you place an Arrival Gate, you still have to designate a Spawn Room. It determines the structure of your Dojo and which rooms have to be deleted before deleting other rooms. I should probably change the wording in DojoCAD to say "Spawn Room", which is what the game calls it, instead of "Spawn Point", to be less confusing, but you do still need one.

buff0000n commented 8 months ago

@Dilgins Okay, I think you finally pushed me over the edge to taking action. You can now mark your Spawn Room and Arrival gate separately

Screen Shot 2024-01-07 at 5 32 03 AM
AtSburbsEnd commented 8 months ago

Could you add a checkbox for already built rooms so that their required resources don't affect the counter at the bottom? The "Total Resources" button only shows what's needed to build the rest but doesn't include things that have been checked off.

Otherwise, works great and thank you so much for this tool.